:wave: Hello, team! I want to fix this issue <http...
# wiremock-python
a
👋 Hello, team! I want to fix this issue https://github.com/wiremock/python-wiremock/issues/95. Should I work on
version_3
branch? Or should I create a PR directly on
master
branch?
t
Hi, thanks for helping out! I suggest the master branch as the place to work from.
a
Thank you for the quick response! Then I will try to do it on the
master
branch.
I have another question: shouldn't we have some tests that call a live WireMock service, like maybe a WireMock running in a container? From what I observed, the tests we currently have only mock the WireMock service. Please correct me if I’m mistaken.
t
There are a few integration tests in there IIRC, but we’d definitely benefit from a load more of them, ideally via the Testcontainers integration.
a
https://github.com/wiremock/python-wiremock/pull/108 I created this PR. Is there a stage for running tests, or is running them locally enough?