<@U06SLD8CDCG> <@U0572D35PA7> I think I’ve just su...
# wiremock-java
t
@Tomas Bjerre @Maciej Krakowiak I think I’ve just successfully released the WireMock Spring integration via our new process under the group
org.wiremock.integrations
, version 2.2.0. Please could one/both of you have a quick look and see if it’s OK?
👍 1
t
• Perhaps I should be here? https://github.com/wiremock/wiremock-spring-boot/blob/dde077a6d6bed7e6e8380e5f266d7b9c7247ee0f/gradle.properties#L18 • Perhaps you prefer using a renovate bot? Or was there some problem with my
update-versions
plugin? https://github.com/wiremock/wiremock-spring-boot/blob/dde077a6d6bed7e6e8380e5f266d7b9c7247ee0f/build.gradle#L10 • Was the
next
-version intended? https://repo1.maven.org/maven2/org/wiremock/integrations/wiremock-spring-boot-standalone/next/ • Does the standalone jar really work? With the spring dependencies inside that jar? Do you see a use case for it? • I was preparing for a
3.0.0
release. I took the opportunity to make some breaking changes. The CHANGELOG was sort of work in progress but it is here: https://github.com/wiremock/wiremock-spring-boot/blob/main/CHANGELOG.md#300
t
• Happy to change it to your name if Maciej is happy for you to be named as primary maintainer. • We use Dependabot for this everywhere else, so that was what I intended here. • No,
next
was me screwing up the first attempt at releasing. • No idea whether standalone works. Was hoping one of you could tell me! (if not, we can stop publishing that) • Should we push a 3.0.0 release right away, or do you want to finalise some changes, then we do it?
👍 1
t
I have no more changes I want to do for 3.0.0. I think we should push that.
Also think it would be good to not include the standalone. Perhaps there will be issues reported on it and I don't see why anyone would need it.
t
OK, I’ll tweak it not to publish standalone and then we can ship a 3.0.0 release. Are you able to edit the
next
release note to add all your 3.0.0 changes?
It might even be possible for you to trigger the release
t
The
gradle-wiremock-extension-plugins
was a nice surprise, it triggered me to rewrite my own scripts. But I think the Shadow jar should be opted out in some use cases. Tried to get a conversation going on that here https://github.com/wiremock/gradle-wiremock-extension-plugins/pull/20
Was able to create a draft, bu I never used that feature before: https://github.com/wiremock/wiremock-spring-boot/releases/edit/untagged-efad8ca83fec33a5745c
t
Can you edit the one called next rather than creating a new draft?
Going forward the next release will be automatically created by the Release Drafter workflow, which will collect all the PRs that have been merged and attempt to group them by type. Makes it a lot easier to write the release note, rather than doing it from scratch.
I think I’ve just disabled standalone publishing…
👍 1
t
I clicked on save, perhaps I should have saved draft...
t
Before you try again: • Publishing the release triggers the actual release process • You must tell it to set a new tag to the version you want • You also need to change the release title to the version number
t
It is OK if I try that now?
t
Sure
t
"tell it to set a new tag to the version you want"
How do I do that?
t
image.png
I need to go offline for 30 minutes, but I’ll check how it’s going when I’m back
(train wifi permitting)
👍 1
t
Looking good!
And no standalone this time
👍 1
t
I'm not sure it should be the
package org.wiremock.spring;
in the code now that it has groupId
org.wiremock.integrations
. But not a big thing I guess.
t
Nobody ever thanks you for changing the java package in my experience 🙂
👍 1
t
Thanks a lot for helping with this initial release. Hope @Maciej Krakowiak is totally fine with what is happening. I will hopefully battle test this tomorrow at work, and finally start using WireMock 3 there! 😃
t
Thanks for all your help getting it in shape!