My employer is using Wiremock with Springboot 3 wi...
# general
t
My employer is using Wiremock with Springboot 3 with [spring-cloud-contract](https://github.com/spring-cloud/spring-cloud-contract). They are really slow at adopting Wiremock 3: https://github.com/spring-cloud/spring-cloud-contract/pull/2092#issuecomment-2124597534 I considered switching to [wiremock-spring-boot](https://github.com/maciejwalkowiak/wiremock-spring-boot) but that seems abandoned, I'm not getting any feedback on my issues and PRs https://github.com/maciejwalkowiak/wiremock-spring-boot/issues Perhaps we can start maintaining a fork of wiremock-spring-boot in the Wiremock organization?
t
I’ve been considering this for a while actually (maybe not a fork necessarily, but an official integration), since Spring is such a common environment in which WireMock is used. Would you be up for taking the lead on this?
t
Yes. I think I would fork that repo to Wiremock organization and try to fix the open issues. Or do you prefer another approach?
t
That sounds like a great approach. I seem to remember the Marcin (who maintains that project) being quite active on GH and social media a while ago so I think it’d be good to get in touch with him and discuss what we’re planning. He may want to become active in the project again if he’s getting some help and it’s been made part of the WireMock org.
Sorry Maciej, not Marcin! Getting mixed up with the Spring project member who maintains their WireMock extension.
👍 1
I’ve dropped him a message, so we’ll see how that goes
t
I also sent an email, no response. And no response in any issue/PR. I spent some time merging the open pull-requests, replaced Maven with Gradle, formatting with Google Java Format, changed namespace to
org.wiremock.spring
and some other minor adjustments: https://github.com/tomasbjerre/wiremock-spring-boot/tree/wiremock-org-fork • Is that good enough to start maintain in the Wiremock org? • Can it be published to `org.wiremock`in Central or should I use my
se.bjurr
like I've done with Pact and Jaxrs?
t
We tend to use org.wiremock.extensions for this kind of project when we host it in the wiremock GH org.
m
Hello! Apologies once again for late reply. I’ve had a break from online activities past months and didn’t get to review @Tomas Bjerre PRs. If you will have time to keep this project alive under Wiremock organisation, I am all in for doing the transfer, just don’t want this project to die as I am also using it in commercial projects with my clients.
t
Thanks again for being willing to contribute this. Given how significant Spring is amongst WireMock users I think it makes a lot of sense for there to be an official WireMock integration that we can nurture and enhance. I’m guessing you’ll still want to remain a committer to the project?
m
Yes I am happy to stay as a committer and help with moving it forward but I won’t be able to dedicate significant time to it. @Tomas Bjerre has lots of interesting ideas and he uses it in wild so i am happy to pass leading the project to him (or you - not sure how the structure in wiremock org works)
t
I’m happy for Tomas to take the lead with this. I have a few ideas also, but my team and I are spread very thinly across the OSS and commercial code.
👍 1
m
Alright. I will only release 2.1.3 with one long overdue PR and then will trigger the transfer. https://github.com/wiremock is the right organisation?
t
Yes, that’s the correct org 👍
m
i can’t transfer as i dont have rights to create repositories in wiremock org. not sure what’s the right way to proceed. Maybe you can give me rights to create repositories for few mins?
t
I feel like there’s a way for you to initiate transfer then me accept…
m
yea me too but
alright transferred directly to you (
tomakehurst
)
then you can transfer to wiremock org
t
Ah OK, thanks. Was going to add you as an org member, which would fix the issue.
I’ve invited you to the org anyway
It still seems to be in your ownership, so maybe you can transfer directly into the org now?
m
let me try
t
We should also change the Maven coordinates, so I’ll get a new project set up in Sonatype.
m
yes, and update github secrets for releases
👍 1
t
Actually, provided we use the
org.wiremock.extensions
group, we don’t need a new project
I’ll share the secrets from the org to the repo
m
project uses jreleaser for pushing artifacts to sonatype and it set up in a way that it requires manual approval of staging repositories. also there’s something off with this setup as it creates first repository with just “parent” module and then second repository with parent and actual project. since there were not too many releases it did not bother me much - i always dropped the first one and release the other one, but it may be soemthing you want to fix
t
Might be worth just porting it to our Gradle plugin that handles all the release heavy lifting
m
up to you and @Tomas Bjerre now 🙂
👍 2