Hi there, I recently started using Wiremock and im...
# wiremock-java
b
Hi there, I recently started using Wiremock and immediately got hit by https://github.com/wiremock/wiremock/issues/1756 🙈 I'd be willing to contribute a pull request but would like to have your opinion first about what should be done. While I am personally +1 for changing the default, a non-breaking quick-win could also be to change the documentation and only support configuring
failOnUnmatchedRequests
via annotation property as well. WDYT?
t
Thanks for the offer to contribute. I agree the default should be to fail (this is how the older JUnit rule works) but changing it on a minor version would be a bad idea. So I suggest we fix the docs for now, and flip the default (and the doc) in 4.0.
b
Thanks for the quick response. How far away is 4.0? Asking to find out whether it might make sense to still implement a way to configure it via annotation until then.
t
We were starting to discuss it today as the pressure to get the min Java version up to 17 is starting to increase, but it’s not going to be particularly quick. Almost certainly not this quarter.
✅ 1